Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ ihmc-ros2-library 1.1.0 #484

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

⬆️ ihmc-ros2-library 1.1.0 #484

wants to merge 9 commits into from

Conversation

ds58
Copy link
Contributor

@ds58 ds58 commented Nov 19, 2024

No description provided.

@ds58 ds58 force-pushed the ros2-library-upgrade branch from 8ba69a4 to 87cd6e0 Compare December 5, 2024 17:26
@ds58 ds58 changed the title Upgrade ihmc-ros2-library ⬆️ ihmc-ros2-library 1.1.0 Dec 5, 2024
@ds58 ds58 marked this pull request as ready for review December 9, 2024 19:11
@ds58 ds58 requested review from calvertdw and TomaszTB December 9, 2024 19:20
@@ -48,73 +41,12 @@ public final class ROS2Tools

public static final ROS2Topic<?> IHMC_ROOT = new ROS2Topic<>().withPrefix(IHMC_TOPIC_PREFIX);

private static final RTPSCommunicationFactory FACTORY = new RTPSCommunicationFactory();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@@ -165,14 +166,54 @@ public void testLongStringCommunication()
ThreadTools.sleepForever();
}

@Test
public void testSharedMemoryROS2Node() throws InterruptedException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@calvertdw calvertdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using the 215 domain ID

Copy link
Contributor

@TomaszTB TomaszTB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo many files to look at.. I really only took a detailed look at files I recognize. Others look good from quick glances. Any idea why some of the tests are failing?

@ds58
Copy link
Contributor Author

ds58 commented Dec 9, 2024

Sooo many files to look at.. I really only took a detailed look at files I recognize. Others look good from quick glances. Any idea why some of the tests are failing?

I don't know. I will have to investigate.

@calvertdw calvertdw self-requested a review December 9, 2024 23:16
ds58 added 2 commits December 11, 2024 09:46
…ajectoryMessage sequence_id, make all sequence_id in messages uint64 instead of uint32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants