Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add romanian locale file #488

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add romanian locale file #488

wants to merge 6 commits into from

Conversation

tiberiufrat
Copy link

Hello! I have added the locale file with Romanian translations.
Thank you!

pacso
pacso reviewed Oct 22, 2021
View reviewed changes
config/locales/ro.yml Outdated Show resolved Hide resolved
pacso
pacso reviewed Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@pacso pacso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Is it worth adding a test similar to spec/examples/to_s_en_spec.rb?

@seejohnrun
Copy link
Collaborator

Do you mind also making an entry in the CHANGELOG? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacso pacso pacso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiberiufrat @seejohnrun @pacso