Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample editor love (on dev branch) #1302

Merged
merged 27 commits into from
Jun 24, 2021
Merged

Sample editor love (on dev branch) #1302

merged 27 commits into from
Jun 24, 2021

Commits on Jun 17, 2021

  1. [SampleEditor] correct volume envelope reading and crash when editiin… 

    …g last envelope point (fixes hydrogen-music#782)
    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    be1610d View commit details
    Browse the repository at this point in the history

  2. envelope editing: remove duplicate code

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    442f146 View commit details
    Browse the repository at this point in the history

  3. wave editors: always track mouse movements

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    89602fd View commit details
    Browse the repository at this point in the history

  4. remove code duplication for envelope painting

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ecd7154 View commit details
    Browse the repository at this point in the history

  5. don't move !

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2bb9383 View commit details
    Browse the repository at this point in the history

  6. using references instead of pointers is nicer

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    086768a View commit details
    Browse the repository at this point in the history

  7. add EnvelopeEditMode enum, more refs instead of pointers

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    453537b View commit details
    Browse the repository at this point in the history

  8. highlight selected/selectable envelope point on mouse moves

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    9546303 View commit details
    Browse the repository at this point in the history

  9. highlight selected frame slider in MainSampleWaveDisplay

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bad9452 View commit details
    Browse the repository at this point in the history

  10. use manhattanLength() to choose frame slider

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f765730 View commit details
    Browse the repository at this point in the history

  11. envelope editing: dont stop dragging when mouse leave widgets

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    a33e62a View commit details
    Browse the repository at this point in the history

  12. allow empty envelopes 

    * deleting first and last point is only allowed when they are the last
ones.
* deleting the first or last point deletes the other end.
* clicking on a wave with an empty envelope inserts to points at both
  ends
    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    9c872f1 View commit details
    Browse the repository at this point in the history

  13. make the main wave widget more intuitive 

    * align logic between SampleEditor & MainSampleWaveDisplay
* don't change slider while dragging so that when you start editing
  start frame, you don't mess with end frame jumps.
    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2b7fe5a View commit details
    Browse the repository at this point in the history

  14. show envelope value only when dragging

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f3e6bc3 View commit details
    Browse the repository at this point in the history

  15. update layer's wave preview on change

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    965be0c View commit details
    Browse the repository at this point in the history

  16. hit enter everywhere in editor to play sample

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    400b42a View commit details
    Browse the repository at this point in the history

  17. use manhattan distance for envelope point selection

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    69cbef3 View commit details
    Browse the repository at this point in the history

  18. avoid crash when no point is selected for removal

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    b11d4f5 View commit details
    Browse the repository at this point in the history

  19. make SampleEditor::m_bSampleEditorClean private & initialize it in ctor

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5bd9059 View commit details
    Browse the repository at this point in the history

  20. add public method InstrumentEditorPanel::updateWaveDisplay()

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    de93d70 View commit details
    Browse the repository at this point in the history

  21. initialize MainSampleWaveDisplay::m_SelectedSlider in ctor

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ad7527c View commit details
    Browse the repository at this point in the history

  22. show envelope point value on hover

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    fae5772 View commit details
    Browse the repository at this point in the history

  23. highlight first and last point also when selected

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2c06958 View commit details
    Browse the repository at this point in the history

  24. factorize some code in MainSampleWaveDisplay

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    8478ce1 View commit details
    Browse the repository at this point in the history

  25. merge envelope points at same frame

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    b00c394 View commit details
    Browse the repository at this point in the history

  26. naming conventions

    @charbeljc
    charbeljc committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    6c9256e View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. update ChangeLog

    @charbeljc
    charbeljc committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d09d796 View commit details
    Browse the repository at this point in the history