Sample editor love (on dev branch) #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g last envelope point (fixes hydrogen-music#782)
* deleting first and last point is only allowed when they are the last ones. * deleting the first or last point deletes the other end. * clicking on a wave with an empty envelope inserts to points at both ends
* align logic between SampleEditor & MainSampleWaveDisplay * don't change slider while dragging so that when you start editing start frame, you don't mess with end frame jumps.
This was referenced Jun 23, 2021
Closed
Closed
theGreatWhiteShark
approved these changes
Jun 24, 2021
You are welcome, thanks you for the quick merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok @theGreatWhiteShark I just did rebase #1301 on development branch