Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(id-class-value): fix ineficient regex #1414

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(id-class-value): fix ineficient regex #1414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5163d31
fix(id-class-value): fix ineficient regex
bebehr Feb 19, 2024
ea7ea2d
fix(id-class-value): fix inefficient regex
bebehr Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/rules/id-class-value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
'The id and class attribute values must be in lowercase and split by a dash.',
},
hump: {
regId: /^[a-z][a-zA-Z\d]*([A-Z][a-zA-Z\d]*)*$/,
regId: /^[a-z](?=[a-zA-Z\d]*$)(?:[a-zA-Z\d]*(?:[A-Z][a-zA-Z\d]*)*)?$/,

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings containing many repetitions of 'A'.
message:
'The id and class attribute values must meet the camelCase style.',
},
Expand Down