fix(id-class-value): fix ineficient regex #1414
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the capturing group quantifier ( ... )* with a non-capturing group quantifier (?: ... )* to reduce the risk of exponential backtracking. htmlhint#1147
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The positive lookahead assertion `(?= ...)` is used to ensure that the check occurs after the first lowercase letter and all subsequent characters have been verified to resolve the issue of reference backtracking htmlhint#1147
| @@ -17,7 +17,7 @@ | |||
| 'The id and class attribute values must be in lowercase and split by a dash.', | |||
| }, | |||
| hump: { | |||
| regId: /^[a-z][a-zA-Z\d]*([A-Z][a-zA-Z\d]*)*$/, | |||
| regId: /^[a-z](?=[a-zA-Z\d]*$)(?:[a-zA-Z\d]*(?:[A-Z][a-zA-Z\d]*)*)?$/, | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the capturing group quantifier ( ... )* with a non-capturing group quantifier (?: ... )* to reduce the risk of exponential backtracking.
#1147
Short description of what this resolves:
Reduce risk of exponential backtracking in rule id-class-value
Proposed changes: