Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapper frontend login + remove temp auth from React frontend #1903

Merged
merged 27 commits into from
Nov 27, 2024
Merged

Mapper frontend login + remove temp auth from React frontend #1903

merged 27 commits into from
Nov 27, 2024

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains the following works:
Mapper Frontend

  • OSM and Temp login add to mapper frontend
  • Remove Temp login from react frontend
  • Change hot-header component with custom header component with drawer

React Frontend

  • Replace Legend Toggle to map control component
  • Add button named START MAPPING to link react frontend to mapper frontend

Screenshots

image
image
image
image

@NSUWAL123 NSUWAL123 requested a review from spwoodcock November 21, 2024 08:41
@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code labels Nov 21, 2024
@NSUWAL123
Copy link
Contributor Author

Oh, the frontend test is failing as we had used a temp login for the playwright test. Now what shall be the alternative?

Creating an OSM account to conduct the e2e test? Would that be feasible?

spwoodcock
spwoodcock approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!

The only thing missing is the cookie refresh behaviour. On first load the refresh endpoint should be called to attempt cookie refresh (and extend it's expiry). The react frontend does this.

Perhaps it can be a follow up PR, as this is great to merge 😄

@spwoodcock
Copy link
Member

Oh, the frontend test is failing as we had used a temp login for the playwright test. Now what shall be the alternative?

Creating an OSM account to conduct the e2e test? Would that be feasible?

Also good point!

I will hold off from merging and look at playwright options for login 👍

Could you look at the refresh action?

@NSUWAL123
Copy link
Contributor Author

Sure!

@NSUWAL123
Copy link
Contributor Author

@spwoodcock the /refresh endpoint called on the first load on mapper frontend has already been implemented by you.
You were mentioning this right? or I am confused.
image

@spwoodcock
Copy link
Member

Yes that's the one!
I must have forgot 😅
Looks like we are set then!
(I'll just fix up the playwright stuff tomorrow then merge)

@spwoodcock spwoodcock changed the title Feat/mapper login Mapper frontend login + remove temp auth from React frontend Nov 22, 2024
@spwoodcock spwoodcock mentioned this pull request Nov 22, 2024
Merged
7 tasks
@NSUWAL123 @spwoodcock
feat(osm-logo): logo add to mapper
bf0bf3c
@NSUWAL123 @spwoodcock
feat(login): login store add
aad8209
@NSUWAL123 @spwoodcock
fix(layer-switcher): close layer-switcher by default
36db3ea
@NSUWAL123 @spwoodcock
feat(login): login dialog popup add
5c15753
@NSUWAL123 @spwoodcock
fix(login): util functions add for login
ee8c818
@NSUWAL123 @spwoodcock
fix(login): store current path on localStorage
37e1afb
@NSUWAL123 @spwoodcock
fix(osmAuth): if user request redirection to mapper frontend then tre…
b0ee2bf 
…at as external url
@NSUWAL123 @spwoodcock
feat(logo): hot logo add
7af73f8
@NSUWAL123 @spwoodcock
fix(header): header component ui slice
bd07a72
@NSUWAL123 @spwoodcock
feat(login): toggle modal state add
02aae8a
@NSUWAL123 @spwoodcock
fix(layout): replace hot-header with custom header component
683f737
@NSUWAL123 @spwoodcock
fix(login): replace modalOpen state on parent with stores
788f7e8
@NSUWAL123 @spwoodcock
fix(+layout): barlow font add to root
67c3071
@NSUWAL123 @spwoodcock
feat(header): display username and profile image if user logged in
b35f8da
@NSUWAL123 @spwoodcock
fix(login): signOut add
a8758a9
@NSUWAL123 @spwoodcock
feat(drawerItems): drawer menu items add
6201053
@NSUWAL123 @spwoodcock
feat(header): drawer comp add, signout func add
7cd63ad
@NSUWAL123 @spwoodcock
fix(layerSwitchMenu): width & height fix
ed25d68
@spwoodcock
test: persist osm login across playwright tests (temp login removed) (#…
71cec9c 
…1910)

* test: wip persist osm login across playwright tests

* test: add temp auth config as a playwright workaround
@github-actions github-actions bot added backend Related to backend code tests Related to automated code tests labels Nov 27, 2024
@spwoodcock spwoodcock merged commit d175979 into development Nov 27, 2024
7 of 8 checks passed
@spwoodcock spwoodcock deleted the feat/mapper-login branch November 27, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
backend Related to backend code enhancement New feature or request frontend Related to frontend code tests Related to automated code tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSUWAL123 @spwoodcock