-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist osm login across playwright tests (temp login removed) #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
frontend
Related to frontend code
tests
Related to automated code tests
labels
Nov 22, 2024
spwoodcock
modified the milestones:
(2024.5.0) general bugfixes / improvements,
Tokha, Nepal mapping project (v2024.5.0)
Nov 24, 2024
This was a lot more complicated that I imagined, due to OpenStreetMap oauth restrictions:
Instead, in this PR I decided to make a simple workaround via temp auth for the React frontend:
|
spwoodcock
force-pushed
the
test/persist-playwright-login
branch
from
November 27, 2024 04:25
7aadaba
to
b3a10aa
Compare
spwoodcock
force-pushed
the
feat/mapper-login
branch
from
November 27, 2024 04:26
1fb76e7
to
fc91a5e
Compare
spwoodcock
force-pushed
the
test/persist-playwright-login
branch
from
November 27, 2024 04:27
b3a10aa
to
d809ea4
Compare
spwoodcock
added a commit
that referenced
this pull request
Nov 27, 2024
β¦1903) * feat(osm-logo): logo add to mapper * feat(login): login store add * fix(layer-switcher): close layer-switcher by default * feat(login): login dialog popup add * fix(login): util functions add for login * fix(login): store current path on localStorage * fix(osmAuth): if user request redirection to mapper frontend then treat as external url * feat(logo): hot logo add * fix(header): header component ui slice * feat(login): toggle modal state add * fix(layout): replace hot-header with custom header component * fix(login): replace modalOpen state on parent with stores * fix(+layout): barlow font add to root * feat(header): display username and profile image if user logged in * fix(login): signOut add * feat(drawerItems): drawer menu items add * feat(header): drawer comp add, signout func add * fix(layerSwitchMenu): width & height fix * fix(mapLegends): fix(mapLegends): show map legend in dropdown * fix(mapControlComponent): add mapLegend to mapControlComponent * fix(projectDetailsV2): remove showing map legend on accordion, btn linking to mapper frontend add * remove(login): remove temporary login from react frontend * test: persist osm login across playwright tests (temp login removed) (#1910) * test: wip persist osm login across playwright tests * test: add temp auth config as a playwright workaround * test: fix mapper flow tests, first open page, then click card * test: disable firefox and webkit tests entirely for now * docs: add note about attempting test auth with webkit * test: use btnTestId prop to identify specific button during tests --------- Co-authored-by: Sam <[email protected]> Co-authored-by: spwoodcock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related
#1903 as the PR where this issue was discussed
Describe this PR
Alternative Approaches Considered
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?