Add replication factor to block meta [1 of 3] #3628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds replication factor to the block meta and updates the compactors to use it as a grouping parameter. By default is set to 0, even when replication factor is enabled. It's only used in blocks created in the local-blocks processor in the metrics-generator.
It also contains a refactor of
CreateWALBlock()
. Instead of passing individual parameters, it accepts abackend.BlockMeta
. It coalesces creating new blocks for all the different encodings (v2
,vParquet2
,vParquet3
,vParquet4
).It also has a fix to the local-blocks processor when cutting traces immediately.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]