Allow flushing blocks from the local-blocks processor [2 of 3] #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
commented
May 21, 2024
mapno
changed the title
mapno
changed the title
mdisibio
reviewed
May 22, 2024
| if err != nil { | ||
| _ = level.Error(p.logger).Log("msg", "failed to flush a block", "err", err) | ||
|
|
||
| if op.attempts < 3 { |
There was a problem hiding this comment.
Let's copy the behavior of the ingester, which doesn't limit retries on flushing to object storage. This will make it tolerate network or other transient errors as long as needed.
There was a problem hiding this comment.
Isn't allowing infinite retries dangerous?
mapno
requested review from
joe-elliott,
annanay25,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mdisibio
reviewed
May 28, 2024
mdisibio
approved these changes
May 28, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the ability to the local-blocks processor to flush blocks to storage, with the objective of flushing blocks with a replication factor of 1 (see previous PR: #3628).
It adds the
storemodule as a dependency of themetrics-generator. The module is only instantiated when the storage is configured, working as before when it is not configured.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]