Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init deploy-gke Container Action #2

Merged
merged 2 commits into from May 6, 2024
Merged

feat: init deploy-gke Container Action #2

merged 2 commits into from May 6, 2024

Conversation

JeromeJu
Copy link
Contributor

This commit inits the deploy-gke container action. It utlizes the gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within this initial commit.

JeromeJu and others added 2 commits April 15, 2024 13:56
This commit inits the deploy-gke container action. It utlizes the gke-deploy
CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within this
initial commit.
@sethvargo
Copy link
Member

@JeromeJu looks like integration tests are failing. I can force-merge this if you're still working on CI.

@JeromeJu
Copy link
Contributor Author

@JeromeJu looks like integration tests are failing. I can force-merge this if you're still working on CI.

Thanks for the review @sethvargo and yes I am working on the CI - taking a bit time to learn the tf syntax conventions given it's my first time going through it. I will try to put up the CI PR ASAP.

@sethvargo
Copy link
Member

Thanks - you should have access to the test-infra repo. Do you need me to grant GCP IAM permissions so you can create resources in the GCP projects?

@JeromeJu
Copy link
Contributor Author

Thanks - you should have access to the test-infra repo. Do you need me to grant GCP IAM permissions so you can create resources in the GCP projects?

Thanks @sethvargo - yes that would be much appreciated.
I've added google-github-actions/test-infra#65 for the required inputs for the CI workflow. I assume to make this change effective, I would need to set those values up with the IAM account via terraform?

(sorry to get back to this late - I had some issue getting notification within this org I believe earlier but I think it is fixed now; tested with a new PR)

@sethvargo sethvargo merged commit 07f7b4e into release-v0.1.x May 6, 2024
3 of 4 checks passed
JeromeJu added a commit that referenced this pull request May 6, 2024
This commit inits the deploy-gke container action. It utlizes the
gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within
this initial commit.

<!--
Thank you for proposing a pull request! Please note that SOME TESTS WILL
LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from
forks.
Someone from the team will review your Pull Request and respond.

Please describe your change and any implementation details below.
-->

Signed-off-by: JeromeJu <[email protected]>
JeromeJu added a commit that referenced this pull request May 6, 2024
This commit inits the deploy-gke container action. It utlizes the
gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within
this initial commit.

<!--
Thank you for proposing a pull request! Please note that SOME TESTS WILL
LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from
forks.
Someone from the team will review your Pull Request and respond.

Please describe your change and any implementation details below.
-->

Signed-off-by: JeromeJu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants