Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init deploy-gke Container Action #5

Merged
merged 1 commit into from
May 6, 2024

Conversation

JeromeJu
Copy link
Contributor

@JeromeJu JeromeJu commented May 6, 2024

This commit inits the deploy-gke container action. It utlizes the gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within this initial commit.

This commit inits the deploy-gke container action. It utlizes the gke-deploy
CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within this
initial commit.
@JeromeJu JeromeJu requested a review from a team as a code owner May 6, 2024 15:07
@JeromeJu JeromeJu mentioned this pull request May 6, 2024
@JeromeJu
Copy link
Contributor Author

JeromeJu commented May 6, 2024

Hi @sethvargo I've made updates on the integration test given the constraints not to expose public IP(it shall now pass the integration as in #4) PTAL 🙏
I could not make pushes to #2 due to (push declined due to repository rule violations):

remote: error: GH013: Repository rule violations found for refs/heads/release-v0.1.x.
remote: Review all repository rules at http://github.com/google-github-actions/deploy-gke/rules?ref=refs%2Fheads%2Frelease-v0.1.x
remote: 
remote: - Changes must be made through a pull request.
remote: 
remote: - Required status check "cla/google" is expected.
remote: 
remote: - Required status check "integration" is expected.
remote: 
To github.com:google-github-actions/deploy-gke.git
 ! [remote rejected] HEAD -> release-v0.1.x (push declined due to repository rule violations)
error: failed to push some refs to 'github.com:google-github-actions/deploy-gke.git'

As I do not have the permission to rename the default branch - would you mind changing the default branch to main and renaming the release-v0.1.x to release/v0? Thanks

@sethvargo sethvargo merged commit b0872d9 into release-v0.1.x May 6, 2024
2 checks passed
@sethvargo sethvargo deleted the release-patch/v0 branch May 6, 2024 22:43
JeromeJu added a commit that referenced this pull request May 6, 2024
This commit inits the deploy-gke container action. It utlizes the
gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within
this initial commit.

<!--
Thank you for proposing a pull request! Please note that SOME TESTS WILL
LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from
forks.
Someone from the team will review your Pull Request and respond.

Please describe your change and any implementation details below.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants