Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an IOLoop implementation based on asyncio and make it the default if possible #310

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

montag451
Copy link

No description provided.

@ghost
Copy link

ghost commented May 11, 2015

Is there an issue with this pull request?

It would be very useful to be able to use the event loop for custom code instead of being limited to the process or thread models.

@giampaolo
Copy link
Owner

I am sorry this PR totally slipped under my radar. Integrating asyncio into pyftpdlib is something I would definitively like to have! This patch is definitively welcome as it servers as a guidance on how to to integrate the asyncio loop into pyftpdlib but it lacks docs and tests. By any chance, is this is something you would like to work on?

@creatorrr
Copy link

Ping @giampaolo @montag451

Any updates on this? The travis build failure is not very informative but I'd be happy to work on fixing them.

@montag451
Copy link
Author

@creatorrr I'm not using pyftplib anymore it's the reason why this pull request has not seen activities for a long time. I don't think the failure should be difficult to fix because the changes introduced by my pull request are really small. It's nice that someone takes the time to work on this because I really think that pyftplib suffers from the lack of integration with other event loops.

@honglei
Copy link

honglei commented Jun 18, 2023

It works under Python3.11, but asynchat and asyncore have been removed in Python3.12. Six years after the initial commit, any update plan for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants