Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncore and asynchat may be removed from python 3.11 stdlib #560

Open
danifus opened this issue Nov 17, 2021 · 4 comments
Open

asyncore and asynchat may be removed from python 3.11 stdlib #560

danifus opened this issue Nov 17, 2021 · 4 comments

Comments

@danifus
Copy link

danifus commented Nov 17, 2021

There's a discussion on the Python dev mailing list about removing asyncore and asynchat from Python 3.11:
https://mail.python.org/archives/list/[email protected]/thread/LZOOLX5EKOITW55TW7JQYKLXJUPCAJB4/#LVFBHVNV3INGKVVRONVRIA3Q6JIYXMZM

pyftpdlib would need to be migrated to asyncio (#310) or ship with a copy of asyncore and asynchat to continue to work if these modules are removed from the stdlib.

@giampaolo
Copy link
Owner

Yep. I'd say we can just copy latest version of both modules into pyftpdlib directory (pyftpdlib/_asyncore.py and pyftpdlib/_asynchat.py) and import them if we're on python 3.

@danifus
Copy link
Author

danifus commented Nov 17, 2021

Sounds like a good plan :)

@akozyreva
Copy link

Hi! Totally agree. I've got already deprecation warnings on Python 3.10.2 :

venv/lib/python3.10/site-packages/pyftpdlib/handlers.py:5
  /home/akozyreva/projects/......./pyftpdlib/handlers.py:5: DeprecationWarning: The asynchat module is deprecated. The recommended replacement is asyncio
    import asynchat

@honglei
Copy link

honglei commented Jun 18, 2023

https://docs.python.org/3.12/whatsnew/3.12.html#summary-release-highlights

asynchat and asyncore have been removed according to the schedule in PEP 594, having been deprecated in Python 3.6. Use asyncio instead. (Contributed by Nikita Sobolev in gh-96580.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants