Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payments): separate redirect constructor from authorization hook #36

Closed
wants to merge 1 commit into from
Closed

fix(payments): separate redirect constructor from authorization hook #36

wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Nov 15, 2023 •
edited
Loading

Reincarnation of frappe/erpnext#37502 for the same reasons

Sister PR: frappe/payments#57

Please also merge #31

@blaggacao blaggacao mentioned this pull request Nov 15, 2023
Closed
@s-aga-r
Copy link
Contributor

s-aga-r commented Dec 4, 2023

@rohitwaghchaure

@blaggacao
Copy link
Collaborator Author

@rohitwaghchaure This blocks development on a PayZen implementation (or for that matter any [correct] implementation with an IPN — where we can't know if the flow is also return by the client in parallel).

@blaggacao
Copy link
Collaborator Author

@rohitwaghchaure could you please help with this PR?

@GeoCommander
Copy link

@rohitwaghchaure we need to merge this

@blaggacao
Copy link
Collaborator Author

Superseded by frappe/payments#53 and frappe/frappe#25952

@blaggacao blaggacao closed this Apr 15, 2024
@blaggacao blaggacao deleted the fix/authorization_hook branch October 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaggacao @s-aga-r @GeoCommander