fix(payments): separate redirect constructor from authorization hook #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s-aga-r May you find some time to look at this and the companion in frappe/webshop#36? This curreently "blocks" (I'm branching, but it gets ever more complex) me from migrating (and thus eventually contributing) PayZen. |
|
@s-aga-r May we advance on this a little bit as a precursor to some wider improvements/refactorings (and above all contribution of PayZen gateway). I need to first safely migrate to v15 and therefore am dependent on this fix/refactor. |
|
@s-aga-r could we maybe, once again, discuss this change? Not merging appears to force me into maintaining an eternal fork, while the change itself seems reasonable and generic. |
|
Superseded by #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reincarnation of frappe/erpnext#37502 for the same reasons
Sister PR: frappe/webshop#36
This is a prerequisite for PayZen IPN implementation, potentially current IPN implementations harbor a slient bug.