Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-138: Change added as a speaker email #143

Closed
wants to merge 1 commit into from
Closed

fix-138: Change added as a speaker email #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/pretalx/orga/views/submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,18 @@ def create_user_as_orga(email, submission=None, name=None):
kwargs={"event": submission.event.slug, "token": user.pw_reset_token},
)
invitation_text = _(
"""Hi!
"""Hello!

You have been set as the speaker of a proposal to the Call for Participation
of {event}, titled “{title}”. An account has been created for you – please follow
this link to set your account password.
We are excited to inform you that you have been selected as a speaker for {event} with your proposal titled "{title}". To get started, an account has been created for you. Please follow the link below to set your account password:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider breaking the long sentence into two.

The sentence is quite long and could be more readable if broken into two. For example: 'We are excited to inform you that you have been selected as a speaker for {event} with your proposal titled "{title}". To get started, an account has been created for you. Please follow the link below to set your account password.'

Suggested change
We are excited to inform you that you have been selected as a speaker for {event} with your proposal titled "{title}". To get started, an account has been created for you. Please follow the link below to set your account password:
We are excited to inform you that you have been selected as a speaker for {event} with your proposal titled "{title}".
To get started, an account has been created for you. Please follow the link below to set your account password:


{invitation_link}

Afterwards, you can edit your user profile and see the state of your proposal.
Once you have set your password, you can log in to edit your user profile and track the status of your proposal.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Clarify the login instructions.

Consider specifying where the user should log in. For example: 'Once you have set your password, you can log in on our website to edit your user profile and track the status of your proposal.'

Suggested change
Once you have set your password, you can log in to edit your user profile and track the status of your proposal.
Once you have set your password, you can log in on our website to edit your user profile and track the status of your proposal.


The {event} orga crew"""
We look forward to your participation and contribution to {event}.

Best regards,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using a consistent sign-off format.

The sign-off 'Best regards, The {event} Organizing Team' is friendly, but consider if it aligns with other communications sent by the team. Consistency in tone and format can help maintain a professional image.

The {event} Organizing Team"""
).format(
event=submission.event.name,
title=submission.title,
Expand All @@ -102,7 +103,7 @@ def create_user_as_orga(email, submission=None, name=None):
event=submission.event,
reply_to=submission.event.email,
subject=str(
_("You have been added to a proposal for {event}").format(
_("Welcome as a Speaker at {event}!").format(
event=submission.event.name
)
),
Expand Down
Loading