Update RunnerPodSpec to include more fields

[luizbafilho]

Update RunnerPodSpec to include PriorityClassName, SecurityContext, and Resources

Related to #786

[yitsushi]

Are you sure 340 is flaky and not related to you changes?

<                         "spec": <map[string]interface {} | len:1>{
<                             "resources": <map[string]interface {} | len:0>{},
<                         },
---
>                         "spec": <map[string]interface {} | len:0>{},

That diff doesn't feel like a flaky test, it feels like it changes the structure itself.

This is part of the runnerPodTemplate:

                    "runnerPodTemplate": <map[string]interface {} | len:2>{
                        "metadata": <map[string]interface {} | len:0>{},
                        "spec": <map[string]interface {} | len:1>{
                            "resources": <map[string]interface {} | len:0>{},
                        },
                    },

compared to:

                    "runnerPodTemplate": <map[string]interface {} | len:2>{
                        "metadata": <map[string]interface {} | len:0>{},
                        "spec": <map[string]interface {} | len:0>{},
                    },

[yitsushi]

I think it's related to this as it's not a reference (*corev1.ResourceRequirements):

	// Set Resources for the Runner Pod container
	// +optional
	Resources corev1.ResourceRequirements `json:"resources,omitempty"`

@chanwit ? ^^

[yitsushi]

(originally it was a top level comment on the PR, but I moved it to here, easier to discuss)

[luizbafilho]

I saw that but there are runs where it doesn't break (https://github.com/weaveworks/tf-controller/actions/runs/6050809758/job/16510347856), but let me make it a reference, that's an issue anyway.

[yitsushi]

lgtm