fix tfctl install --export not separating yaml objects properly

[matheuscscp]

Hi, I'm trying to fix tfctl install --export so I can deploy tf-controller via plain k8s manifests, like Flux (vs the HelmRelease offered in the guides).

After fixing this --- issue this is the only error left:

➜  tf-controller git:(fix-tfctl-install) ✗ k apply -f tfctrl.yml
serviceaccount/tf-controller unchanged
serviceaccount/tf-runner unchanged
role.rbac.authorization.k8s.io/tf-leader-election-role unchanged
clusterrole.rbac.authorization.k8s.io/tf-manager-role configured
clusterrole.rbac.authorization.k8s.io/tf-runner-role unchanged
rolebinding.rbac.authorization.k8s.io/tf-leader-election-rolebinding unchanged
clusterrolebinding.rbac.authorization.k8s.io/tf-cluster-reconciler unchanged
clusterrolebinding.rbac.authorization.k8s.io/tf-manager-rolebinding unchanged
clusterrolebinding.rbac.authorization.k8s.io/tf-runner-rolebinding unchanged
deployment.apps/tf-controller configured
The CustomResourceDefinition "terraforms.infra.contrib.fluxcd.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
➜  tf-controller git:(fix-tfctl-install) ✗ 

[matheuscscp]

Seems like the error is because kubectl apply generates that last-applied-configuration annotation and it is too big for the CRD, but kubectl apply --server-side works. And it looks like Flux relies heavily in server-side apply, so this should be fine.

Pls merge this PR 🙏

[chanwit]

@matheuscscp Thank you so much for spotting this!

[matheuscscp]

@chanwit would it be possible to cut a release with this? maybe v0.16.0-rc.3? I just learned about GHSA-6hvv-j432-23cv and would like to upgrade by re-installing tf-controller using this fix in the CLI 🙏

[chanwit]

Yep, very soon.
We're waiting for this one #910 to merge and cut the release.

[matheuscscp]

@chanwit could you pls cut a release? 🙏 Thanks in advance!

[chanwit]

We planned to do so this week.
Sorry for the delay.