Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make element embedding demo show up under "Web Demos" section #1837

Merged
merged 1 commit into from
May 23, 2023
Merged

Make element embedding demo show up under "Web Demos" section #1837

merged 1 commit into from
May 23, 2023

Conversation

johnpryan
Copy link
Contributor

@johnpryan johnpryan commented May 23, 2023 •
edited
Loading

Using the "demo" type will make the sample visible under the Web Demos section of the site. cc: @ditman

@johnpryan johnpryan requested a review from parlough May 23, 2023 17:58
@ditman
Copy link
Member

ditman commented May 23, 2023 •
edited
Loading

Ahhh very cool, #TIL! Thanks for doing this @johnpryan, @parlough!

@johnpryan johnpryan mentioned this pull request May 23, 2023
Open
@johnpryan
Copy link
Contributor Author

This looks good to merge, since verify-web-demos is passing. I filed an issue for the failing test: #1838

@johnpryan johnpryan merged commit de8fc4d into flutter:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnpryan @ditman @parlough