Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veggieseasons restoration smoke test is failing #1838

Open
johnpryan opened this issue May 23, 2023 · 4 comments
Open

Veggieseasons restoration smoke test is failing #1838

johnpryan opened this issue May 23, 2023 · 4 comments
Assignees
Labels

Comments

@johnpryan
Copy link
Contributor

A test in veggieseasons is failing: https://github.com/flutter/samples/actions/runs/5060535147/jobs/9083548830, which seems unrelated to the PR: #1837

/home/runner/work/samples/samples/veggieseasons/test/restoration_test.dart: restoration smoke test (failed)
  ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
  The following TestFailure was thrown running a test:
  Expected: no matching nodes in the widget tree
    Actual: _TextFinder:<exactly one widget with text "In season today" (ignoring offstage widgets):
  Text("In season today", inherit: true, color: label(*color = Color(0xff000000)*, darkColor =
  Color(0xffffffff), resolved by: Builder), family: NotoSans, size: 32.0, weight: 700, style: normal,
  letterSpacing: -0.4, decoration: TextDecoration.none, dependencies: [DefaultSelectionStyle,
  DefaultTextStyle, MediaQuery])>
     Which: means one was found but none were expected
  
  When the exception was thrown, this was the stack:
  #4      main.<anonymous closure> (file:///home/runner/work/samples/samples/veggieseasons/test/restoration_test.dart:34:5)
  <asynchronous suspension>
  <asynchronous suspension>
  (elided one frame from package:stack_trace)
  
  This was caught by the test expectation on the following line:
    file:///home/runner/work/samples/samples/veggieseasons/test/restoration_test.dart line 34
  The test description was:
    restoration smoke test
  ════════════════════════════════════════════════════════════════════════════════════════════════════
  Test failed. See exception logs above.
  The test description was: restoration smoke test
@johnpryan johnpryan changed the title GitHub actions failing Veggieseasons restoration smoke test failing May 23, 2023
@johnpryan johnpryan changed the title Veggieseasons restoration smoke test failing Veggieseasons restoration smoke test is failing May 23, 2023
@johnpryan
Copy link
Contributor Author

I can't reproduce locally, the test looks like it's only failing in CI.

@domesticmouse
Copy link
Contributor

@RedBrogdon do you remember who implemented state restoration for Veggie Seasons? We might need some help with debugging CI.

@parlough
Copy link
Member

parlough commented May 24, 2023

Looks like the 7.1.0 release of go_router is the cause, but I don't have time to dive into what needs to change currently.

@domesticmouse
Copy link
Contributor

Blocked on flutter/flutter#127518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants