-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] Updates README.md
with examples of using @ProxyApi
#8087
Draft
bparrishMines
wants to merge
19
commits into
flutter:main
Choose a base branch
from
bparrishMines:pigeon_readme_proxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,562
−15
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cbed4cf
start of the readme
bparrishMines 8b727c1
Merge branch 'main' of github.com:flutter/packages into pigeon_readme…
bparrishMines 62af46d
start of example creation
bparrishMines cf31e35
move annotation example update dart input code
bparrishMines 83ffee8
generate code and update example readme
bparrishMines fdffa77
add kotlin example
bparrishMines 01e37ac
add dart class example
bparrishMines c495256
ios example
bparrishMines c0c3faf
update project
bparrishMines f9743c5
add more explanation
bparrishMines fc939af
version bump
bparrishMines fc79a96
fix name
bparrishMines e0e170c
fix missing error classes
bparrishMines 4d2fd91
Merge branch 'main' of github.com:flutter/packages into pigeon_readme…
bparrishMines 19ccebf
remove the condition
bparrishMines 9bbdad5
Merge branch 'main' of github.com:flutter/packages into pigeon_readme…
bparrishMines 9d03b96
try again
bparrishMines 1193399
fix tests
bparrishMines 33c4284
Merge branch 'main' of github.com:flutter/packages into pigeon_readme…
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
.../example/app/android/app/src/main/kotlin/dev/flutter/pigeon_example_app/ExampleLibrary.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
@file:Suppress("unused") | ||
|
||
// #docregion simple-proxy-class | ||
package dev.flutter.pigeon_example_app | ||
|
||
open class SimpleExampleNativeClass(val aField: String, private val aParameter: String) { | ||
open fun flutterMethod(aParameter: String) {} | ||
|
||
fun hostMethod(aParameter: String): String { | ||
return "aString" | ||
} | ||
} | ||
// #enddocregion simple-proxy-class | ||
|
||
class ComplexExampleNativeClass : ExampleNativeSuperClass(), ExampleNativeInterface { | ||
val anAttachedField = ExampleNativeSuperClass() | ||
|
||
companion object { | ||
val aStaticField = ExampleNativeSuperClass() | ||
|
||
fun staticHostMethod(): String { | ||
return "some string" | ||
} | ||
} | ||
|
||
override fun inheritedInterfaceMethod() {} | ||
} | ||
|
||
open class ExampleNativeSuperClass { | ||
fun inheritedSuperClassMethod(): String { | ||
return "some string" | ||
} | ||
} | ||
|
||
interface ExampleNativeInterface { | ||
fun inheritedInterfaceMethod() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code didn't compile until I fixed this. I'm assuming our CI doesn't verify the example compiles. Is this unintentional?
I also had to fix the same line for Kotlin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran into this in my pr as well. Not sure why the examples are getting compiled in ci though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8731158450509496993/+/u/Run_package_tests/build_examples/stdout
O.o
Let me look into what's going on here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it's because the actual example is
example/app/
, notexample/
, butexample.pubspec.yaml
exists so the tooling sees thatexample
is a package.I'll play with fixing this in a separate PR. I think the pubspec may have only been there for the old excerpt system.