[pigeon] Updates README.md with examples of using @ProxyApi
#8087
Conversation
| @@ -284,7 +284,7 @@ private class PigeonFlutterApi { | |||
| aString aStringArg: String?, completion: @escaping (Result<String, Error>) -> Void | |||
| ) { | |||
| flutterAPI.flutterMethod(aString: aStringArg) { | |||
| completion(.success($0)) | |||
| completion(.success(try! $0.get())) | |||
There was a problem hiding this comment.
Code didn't compile until I fixed this. I'm assuming our CI doesn't verify the example compiles. Is this unintentional?
I also had to fix the same line for Kotlin.
There was a problem hiding this comment.
Just ran into this in my pr as well. Not sure why the examples are getting compiled in ci though
There was a problem hiding this comment.
============================================================
|| Running for packages/pigeon [@0:00]
============================================================
Building for: Android
Skipping Android for pigeon/example; not supported.
SKIPPING: No examples found supporting requested platform(s).
O.o
Let me look into what's going on here.
There was a problem hiding this comment.
Ah, it's because the actual example is example/app/, not example/, but example.pubspec.yaml exists so the tooling sees that example is a package.
I'll play with fixing this in a separate PR. I think the pubspec may have only been there for the old excerpt system.
| @@ -118,7 +118,7 @@ Future<int> generateTestPigeons( | |||
| ? null | |||
| : '$outputBase/ios/Classes/$pascalCaseName.gen.swift', | |||
| swiftErrorClassName: swiftErrorClassName, | |||
| swiftIncludeErrorClass: input != 'core_tests', | |||
| swiftIncludeErrorClass: input != 'background_platform_channels', | |||
There was a problem hiding this comment.
Fixes a test failure caused by #7849
tldr:
This wasn't caught by CI because core_tests is checked in and the order of the tests matters.
When I reran the generator and pushed my code, it removed the PigeonError from core_tests. Therefore the tests that run before the CI generates the unchecked in files would fail because core_tests was missing the reference to PigeonError that was in background_platform_channels. Therefore the fix was to switch the location of the single PigeonError to reside in core_tests instead of background_platform_channels.
There was a problem hiding this comment.
This is also addressed in my current pr. Your solution is smarter than mine :)
bparrishMines
changed the title
README.md with examples of using @ProxyApi
bparrishMines
requested review from
hellohuanlin,
LouiseHsu and
tarrinneal
as code owners
|
We should hold off on this until I've had a chance to discuss with folks about overall interop plans. |
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.