Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed an issue where there wasn't enough space to right click folders in Column View #15044

Merged
merged 1 commit into from Mar 25, 2024
Merged

Fix: Fixed an issue where there wasn't enough space to right click folders in Column View #15044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Files.App/Views/Layouts/ColumnLayoutPage.xaml
View file
Open in desktop
Expand Up @@ -175,6 +175,7 @@
<SemanticZoom.ZoomedInView>
<ListView
x:Name="FileList"
Padding="8,0,8,0"
wct:ScrollViewerExtensions.EnableMiddleClickScrolling="{x:Bind IsMiddleClickToScrollEnabled, Mode=OneWay}"
x:FieldModifier="public"
AllowDrop="{x:Bind InstanceViewModel.IsPageTypeSearchResults, Converter={StaticResource BoolNegationConverter}, Mode=OneWay}"
Expand All @@ -190,6 +191,7 @@
IsDoubleTapEnabled="True"
IsRightTapEnabled="True"
IsTabStop="True"
ItemContainerTransitions="{x:Null}"
ItemsSource="{x:Bind CollectionViewSource.View, Mode=OneWay}"
Loaded="FileList_Loaded"
PreviewKeyDown="FileList_PreviewKeyDown"
Expand All @@ -199,12 +201,6 @@
SelectionMode="Extended"
Tapped="FileList_ItemTapped">

<ListView.ItemContainerTransitions>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit unrelated but it makes the Column View consistent with the Grid View in this regard.

<TransitionCollection>
<AddDeleteThemeTransition />
</TransitionCollection>
</ListView.ItemContainerTransitions>

<ListView.ItemTemplate>
<DataTemplate x:DataType="filesystem:ListedItem">
<Grid
Expand Down
8 changes: 1 addition & 7 deletions src/Files.App/Views/Layouts/DetailsLayoutPage.xaml
View file
Open in desktop
Expand Up @@ -235,6 +235,7 @@
FocusVisualSecondaryThickness="0"
IsDoubleTapEnabled="True"
IsTabStop="True"
ItemContainerTransitions="{x:Null}"
ItemsSource="{x:Bind CollectionViewSource.View, Mode=OneWay}"
Loaded="FileList_Loaded"
LosingFocus="FileList_LosingFocus"
Expand All @@ -246,13 +247,6 @@
Tapped="FileList_ItemTapped"
Visibility="{x:Bind FolderSettings.IsLayoutModeChanging, Converter={StaticResource NegatedBoolToVisibilityConverter}, Mode=OneWay}">

<!-- ListView Item Transitions -->
<ListView.ItemContainerTransitions>
<TransitionCollection>
<AddDeleteThemeTransition />
</TransitionCollection>
</ListView.ItemContainerTransitions>

<!-- ListView Header -->
<ListView.Header>
<Grid
Expand Down