Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where there wasn't enough space to right click folders in Column View #15044

Merged
merged 1 commit into from Mar 25, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Mar 25, 2024

… Column View

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add extra space in column layout for right clicking #15012...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirmed there is now enough room to right click folders in the Column View

Screenshots (optional)
Add screenshots here.

@@ -199,12 +201,6 @@
SelectionMode="Extended"
Tapped="FileList_ItemTapped">

<ListView.ItemContainerTransitions>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit unrelated but it makes the Column View consistent with the Grid View in this regard.

@yaira2 yaira2 merged commit bdc78e5 into main Mar 25, 2024
5 checks passed
@yaira2 yaira2 changed the title Fix: Fixed an issue where there wasn't space to right click folder in… Fix: Fixed an issue where there wasn't space to right click folder in Column View Mar 25, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue where there wasn't space to right click folder in Column View Fix: Fixed an issue where there wasn't enough space to right click folders in Column View Apr 4, 2024
@yaira2 yaira2 deleted the ya/ColumnViewSpacing branch April 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add extra space in column layout for right clicking
1 participant