Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove .eslintrc.js file #207

Merged
merged 1 commit into from Apr 25, 2024
Merged

chore: remove .eslintrc.js file #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion eslint.config.js
View file
Open in desktop
Expand Up @@ -17,7 +17,13 @@ module.exports = [
}
},
{
files: ["eslint.config.js", "tests/**/*.js"],
files: ["eslint.config.js"],
rules: {
"n/no-unpublished-require": "off"
}
Comment on lines +21 to +23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also disable this rule globally, since there are no published files in this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add "private": true in package.json - the rule won't report in this case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally forgot about this PR. If there's a better solution for this, feel free to submit a new one.

},
{
files: ["tests/**/*.js"],
languageOptions: {
globals: {
...globals.jest
Expand Down
7 changes: 0 additions & 7 deletions tests/.eslintrc.js
View file
Open in desktop

This file was deleted.