Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove .eslintrc.js file #207

Merged
merged 1 commit into from Apr 25, 2024
Merged

chore: remove .eslintrc.js file #207

merged 1 commit into from Apr 25, 2024

Conversation

mdjermanovic
Copy link
Member

Removes now unused tests/.eslintrc.js file.

Also updates eslint.config.js to separate configs for this file and test files.

Comment on lines +21 to +23
rules: {
"n/no-unpublished-require": "off"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also disable this rule globally, since there are no published files in this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add "private": true in package.json - the rule won't report in this case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally forgot about this PR. If there's a better solution for this, feel free to submit a new one.

Copy link

@OKEAMAH OKEAMAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Df

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit b818e1b into main Apr 25, 2024
5 checks passed
@nzakas nzakas deleted the remove-eslintrc branch April 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

5 participants