Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3362] Sidebar on mobile #3379

Merged
merged 16 commits into from
May 26, 2023
Merged

[#3362] Sidebar on mobile #3379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2137205
fix: sidebar state on initial loading for default layout
RVitaly1978 Apr 26, 2023
6cb5f9a
fix: code styling in Header and Sidebar components
RVitaly1978 Apr 26, 2023
1088b25
fix: sidebar state on initial loading for default layout
RVitaly1978 Apr 26, 2023
461b978
fix: code styling in Header and Sidebar components
RVitaly1978 Apr 26, 2023
d76e4b7
temp
RVitaly1978 May 2, 2023
1d34ed1
Merge branch 'develop' into 3362-sidebar-on-mobile
RVitaly1978 May 2, 2023
0720563
fix(#3362): hydration node mismatch
RVitaly1978 May 2, 2023
953ee51
style(#3362): code styling in Header
RVitaly1978 May 2, 2023
7969f5a
Merge branch '3362-sidebar-on-mobile' of https://github.com/RVitaly19…
RVitaly1978 May 2, 2023
29e199a
fix(#3362): navbar options SSR rendering
RVitaly1978 May 2, 2023
dca497a
Merge branch 'develop' into 3362-sidebar-on-mobile
RVitaly1978 May 18, 2023
a5eb68d
#3362: fix hydration issue
RVitaly1978 May 23, 2023
331f535
Merge branch 'develop' into 3362-sidebar-on-mobile
RVitaly1978 May 25, 2023
1b42dae
Merge branch 'develop' into 3362-sidebar-on-mobile
RVitaly1978 May 25, 2023
c6f86ce
Merge branch 'develop' into 3362-sidebar-on-mobile
RVitaly1978 May 26, 2023
1aed5e8
#3362: review suggestions
RVitaly1978 May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docs/components/layout/header/HeaderSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default defineComponent({
props: {
minimized: {
type: Boolean,
required: true,
default: false,
RVitaly1978 marked this conversation as resolved.
Show resolved Hide resolved
},
},
emits: ['toggle-sidebar'],
Expand Down
5 changes: 4 additions & 1 deletion packages/docs/layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<aside class="docs-layout__sidebar">
<LayoutSidebar
v-model:visible="isSidebarVisible"
:mobile="breakpoints.sm"
:mobile="isMobileSidebar"
RVitaly1978 marked this conversation as resolved.
Show resolved Hide resolved
/>
</aside>
<main class="docs-layout__main-content">
Expand All @@ -38,12 +38,14 @@ const breakpoints = useBreakpoint()

const isSidebarVisible = ref(false)
const isOptionsVisible = ref(false)
const isMobileSidebar = ref(false)

applyPreset(cookie.value || 'light')

watch(() => breakpoints.smDown, (newValue: boolean) => {
isSidebarVisible.value = !newValue
isOptionsVisible.value = false
isMobileSidebar.value = newValue
})

const { afterEach } = useRouter()
Expand All @@ -57,6 +59,7 @@ afterEach(() => {
onMounted(() => {
scrollToElement()
isSidebarVisible.value = !breakpoints.smDown
isMobileSidebar.value = breakpoints.smDown
})

useHead({
Expand Down