Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3362] Sidebar on mobile #3379

Merged
merged 16 commits into from
May 26, 2023
Merged

[#3362] Sidebar on mobile #3379

merged 16 commits into from
May 26, 2023

Conversation

RVitaly1978
Copy link
Member

@RVitaly1978 RVitaly1978 commented Apr 27, 2023 •
edited
Loading

Description

close #3362

Screen.Recording.2023-05-02.at.13.50.03.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@RVitaly1978 RVitaly1978 added the docs packages/docs label Apr 27, 2023
@RVitaly1978 RVitaly1978 requested a review from m0ksem April 27, 2023 09:54
@RVitaly1978 RVitaly1978 self-assigned this Apr 27, 2023
m0ksem
m0ksem requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it always hidden for me... We need maybe use local storage or cookie to show/hide sidebar.

@RVitaly1978 RVitaly1978 requested a review from m0ksem May 2, 2023 10:53
@misterpekert misterpekert self-requested a review May 16, 2023 12:16
misterpekert
misterpekert requested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@misterpekert misterpekert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons to toggle sidebar and menu header are not clickable for me. Always hidden and seems that smth is broken :(

m0ksem
m0ksem requested changes May 23, 2023
View reviewed changes
packages/docs/layouts/default.vue Outdated Show resolved Hide resolved
packages/docs/components/layout/header/HeaderSelector.vue Outdated Show resolved Hide resolved
@RVitaly1978 RVitaly1978 marked this pull request as draft May 23, 2023 16:28
@RVitaly1978 RVitaly1978 marked this pull request as ready for review May 26, 2023 07:23
@m0ksem m0ksem merged commit 8a8658f into epicmaxco:develop May 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterpekert misterpekert misterpekert requested changes

@m0ksem m0ksem m0ksem approved these changes

Assignees

@RVitaly1978 RVitaly1978

Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation bar shown by default on mobile
3 participants
@RVitaly1978 @misterpekert @m0ksem