Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] new search #29

Merged
merged 5 commits into from
Jan 5, 2024
Merged

[feature] new search #29

merged 5 commits into from
Jan 5, 2024

Conversation

ponsfrilus
Copy link
Member

@ponsfrilus ponsfrilus added the enhancement New feature or request label Jan 4, 2024
@ponsfrilus ponsfrilus self-assigned this Jan 4, 2024
obieler
obieler reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@obieler obieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "EPFL Directory" or "EPFL IT Directory" be more correct?

@ponsfrilus
Copy link
Member Author

Instead of EPNET?

@obieler
Copy link
Member

obieler commented Jan 5, 2024 •
edited
Loading

Instead of EPNET?

Yes. EPNET, which stands for EPFL Network, is broader than the directory.

@ponsfrilus
Copy link
Member Author

Instead of EPNET?

Yes. EPNET, which stands for EPFL Network, is broader than the directory.

Here you go (force pushed and reordered commits).

@ponsfrilus ponsfrilus merged commit f0de0e9 into main Jan 5, 2024
2 checks passed
@ponsfrilus ponsfrilus deleted the feature/new-search branch January 5, 2024 12:30
obieler pushed a commit that referenced this pull request Jan 9, 2024
@ponsfrilus @obieler
[feature] new search (#29)
00a032f 
* [feature] add "EPFL map" icon

* [feature] add "EPFL people" icon

* [feature] add "EPFL units" icon

* [feature] add "actu" search

* [feature] add EPNET search
@obieler obieler mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obieler obieler obieler approved these changes

@williambelle williambelle Awaiting requested review from williambelle

@Azecko Azecko Awaiting requested review from Azecko

@Harpogma Harpogma Awaiting requested review from Harpogma

Assignees

@ponsfrilus ponsfrilus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponsfrilus @obieler