[feature] about and help pages #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depend on #26 to place the CSS in the right place. |
ponsfrilus
force-pushed
the
feature/about-and-help-pages
branch
from
8b30231
to
ad1c5d0
Compare
ponsfrilus
force-pushed
the
feature/about-and-help-pages
branch
from
ad1c5d0
to
cbac52e
Compare
obieler
reviewed
Jan 12, 2024
src/views/pages/catalog.ejs
Outdated
| @@ -17,6 +17,6 @@ | |||
| <% }); %> | |||
| </ul> | |||
| </div> | |||
| <%- include('partials/footer'); %> | |||
| <%- include('partials/footer'); include('partials/footer_scripts'); -%> | |||
There was a problem hiding this comment.
I have an error, you should split like you did in about.ejs:
<%- include('partials/footer'); -%> <%- include('partials/footer_scripts');
-%>
src/views/pages/help.ejs
Outdated
| </div> | ||
| </div> | ||
| </div> | ||
| <%- include('partials/footer'); include('partials/footer_scripts'); -%> |
There was a problem hiding this comment.
Same here.
And by the way, what about to include the 'footer_scripts' in footer.ejs?
There was a problem hiding this comment.
The <script> tag should not be in the <footer> tag. And keeping them both in the page's file would allow us to uses variables when including the template (see "includes" on https://ejs.co): this would be convenient if we don't want every script loaded on every page.
ponsfrilus
force-pushed
the
feature/about-and-help-pages
branch
from
cbac52e
to
6883356
Compare
Done. |
ponsfrilus
force-pushed
the
feature/about-and-help-pages
branch
from
6883356
to
61c6e7b
Compare
Merged
williambelle
approved these changes
Jan 18, 2024
obieler
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the base for
/helpand/aboutpages.