Dev infrastructure #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11903713816Details
💛 - Coveralls |
Merged
dvdplm
approved these changes
Nov 18, 2024
dvdplm
reviewed
Nov 18, 2024
| /// Same as [`run_sync()`], but enables a [`tracing`] subscriber that prints the tracing events to stdout, | ||
| /// taking options from the environment variable `RUST_LOG` (see [`mod@tracing_subscriber::fmt`] for details). | ||
| #[allow(clippy::type_complexity)] | ||
| pub fn run_sync_with_tracing<EP, SP>( |
There was a problem hiding this comment.
What is the point of actually providing two flavours of this? Like, why can't we have only run_sync (and make it use tracing)?
There was a problem hiding this comment.
The basic run_sync is used for benchmarks. With test-log I guess we don't need to provide a special function anymore.
Merged
fjarri
force-pushed
the
dev-infrastructure
branch
from
048f007 to
59aec37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #68
ExecutionResultandrun_sync_with_tracing(), to remove some boilerplate from teststestingmodule and feature todevto avoid confusion withtest