Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CorrectnessProof #72

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Nov 15, 2024

Stacked on top of #71

Closes #2

  • Remove CorrectnessProof.
  • Since FinalizeError only contains LocalError now, it is removed as well and replaced with just LocalError.

I think it is safe to assume that any attributable error in the protocol would occur at receive_message() stage. At least for now, I would like to see an example of a protocol where it is not the case.

@fjarri fjarri self-assigned this Nov 15, 2024
@fjarri fjarri requested a review from dvdplm November 15, 2024 22:23
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11903791955

Details

  • 48 of 49 (97.96%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.0%) to 69.607%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/session/session.rs 29 30 96.67%
Files with Coverage Reduction New Missed Lines %
manul/src/session/transcript.rs 1 57.23%
Totals Coverage Status
Change from base Build 11903754480: 1.0%
Covered Lines: 1807
Relevant Lines: 2596

💛 - Coveralls

@fjarri fjarri force-pushed the remove-correctness-proof branch from 5db29ea to 699ddab Compare November 19, 2024 00:32
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

@fjarri fjarri merged commit 6bec7fc into entropyxyz:master Nov 19, 2024
8 checks passed
@fjarri fjarri deleted the remove-correctness-proof branch November 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test for correctness proof generation and checking
3 participants