-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop prefixer #3296
base: next
Are you sure you want to change the base?
Drop prefixer #3296
Conversation
🦋 Changeset detectedLatest commit: 37fa86e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically agree with this (and probably agree with shipping it in the next major in a way that I don't really with #3294) with the caveat that to understand whether all of it is actually obselete, it'd be good to see something like: run the stylis prefixer over some specifically generated css to exercise all the properties that stylis prefixes, compare that with caniuse/mdn compat data/whatever and see what we get
Quick look on caniuse:
|
Sorry, I looked more into this before the holidays and got side-tracked, basically my thoughts are since the number of properties where prefixes are still relevant seems to be not nothing, I think we should probably have a smaller prefixer that includes what is currently prefixed but excluding everything that is Baseline "Widely Available" (I don't think the estimated browser support percentages to decide things is very useful). Over time, it would shrink, though the exact details of how we'd want to do that wrt to major versions, I'm not super sure about. |
closes #2747
IMHO, this plugin is not really needed in 2025, but I haven't rechecked whether all the included rules are obsolete. Many are, we definitely shouldn't be prefixing flexbox