Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Remove prefix #44921

Open
oliviertassinari opened this issue Jan 2, 2025 · 2 comments
Open

[system] Remove prefix #44921

oliviertassinari opened this issue Jan 2, 2025 · 2 comments
Labels
dx Related to developers' experience external dependency Blocked by external dependency, we can’t do anything about it package: system Specific to @mui/system performance priority: important This change can make a difference

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 2, 2025

Summary

As far as I know, prefixes are no longer needed for the last 12+ months. I don't know any of https://mui.com/material-ui/getting-started/supported-platforms/#browser that requires it.

Now, considering that those are pure pain from a DX perspective. e.g. -webkit-box-pack 🤡
SCR-20250103-bamg
https://mui.com/material-ui/react-button/

and bundle size. https://pkg-size.dev/stylis

SCR-20250103-bbjb

I think it's time we remove them.

Now, to test whether this is true or not. If we can't do it right now, to move to v7. cc @brijeshb42

Examples

emotion-js/emotion#3296

Motivation

Stay relevant.

Search keywords: -

@oliviertassinari oliviertassinari added performance priority: important This change can make a difference package: system Specific to @mui/system status: waiting for maintainer These issues haven't been looked at yet by a maintainer dx Related to developers' experience labels Jan 2, 2025
@siriwatknp
Copy link
Member

siriwatknp commented Jan 3, 2025

I believe nothing to do on our side since the prefixer is used internally by Emotion. There is a PR to remove it in Emotion v12.

User can opt-out from prefixer in v6 by provide a custom cache.stylisPlugins.

@siriwatknp siriwatknp added external dependency Blocked by external dependency, we can’t do anything about it and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 3, 2025
@oliviertassinari
Copy link
Member Author

@siriwatknp It's a breaking change for emotion, it might take some time before they make the change.

In any cases, we have to also remove this because we tell people in our docs to add the prefixer.

Now, if it's not a breaking change for us and we have to do work anyway. Why not work on this now, as a quick win?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Related to developers' experience external dependency Blocked by external dependency, we can’t do anything about it package: system Specific to @mui/system performance priority: important This change can make a difference
Projects
None yet
Development

No branches or pull requests

2 participants