Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemap generator #64

Merged
merged 3 commits into from
Jul 3, 2021
Merged

Sitemap generator #64

merged 3 commits into from
Jul 3, 2021

Conversation

doomspork
Copy link
Member

@doomspork doomspork commented Jun 13, 2021 •
edited
Loading

Add two new Mix tasks to the project:

  1. mix school_house.gen.rss - create an rss.xml feed for the blog
  2. mix school_house.gen.sitemap - create a sitemap.xml with all translated lessons, pages, and blog posts

Both of these files are ignored by git and will be generated on deployments inside the dockerfile.

Part of #59
Closes #54 #62

@doomspork doomspork added elixir This work requires Elixir changes enhancement New feature or request labels Jun 13, 2021
@doomspork doomspork mentioned this pull request Jun 13, 2021
Closed
@doomspork doomspork force-pushed the sitemap-generator branch from ab6be6b to acaf54a Compare June 14, 2021 02:18
kinson
kinson reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@kinson kinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions...take 'em or leave 'em 😄

test/school_house_web/controllers/live/conference_live/index_test.exs Show resolved Hide resolved
lib/school_house_web/router.ex Outdated Show resolved Hide resolved
lib/school_house/content/post.ex Outdated Show resolved Hide resolved
@doomspork
Copy link
Member Author

@kinson great feedback! This is wonderful, thank you for taking the time to do this 💜

@doomspork doomspork force-pushed the sitemap-generator branch from 9f6debc to 9aaa18f Compare June 15, 2021 12:49
@doomspork doomspork force-pushed the sitemap-generator branch 2 times, most recently from 4a99e89 to bca9dc4 Compare June 24, 2021 00:53
@doomspork doomspork force-pushed the sitemap-generator branch from bca9dc4 to b69accc Compare June 24, 2021 15:58
@doomspork doomspork requested a review from kinson June 24, 2021 17:43
@doomspork
Copy link
Member Author

@kinson will you take a peek at this and approve it if you're happy with the code? I'll work on verifying the Dockerfile works as expected this evening.

kinson
kinson reviewed Jun 24, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
kinson
kinson approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@kinson kinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪🏼

I'll leave the Dockerfile multi-line comment up to you to decide on. I could go either way on that one.

@doomspork @kinson
Update Dockerfile
ef141f9 
Co-authored-by: Sam Hunter <[email protected]>
@doomspork doomspork merged commit 6e275d5 into master Jul 3, 2021
@doomspork doomspork deleted the sitemap-generator branch July 3, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinson kinson kinson approved these changes

@burden burden Awaiting requested review from burden

@gemantzu gemantzu Awaiting requested review from gemantzu

Assignees
No one assigned
Labels
elixir This work requires Elixir changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RSS feed support for the blog
2 participants
@doomspork @kinson