Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to Launch #59

Closed
doomspork opened this issue Jun 11, 2021 · 9 comments
Closed

Road to Launch #59

doomspork opened this issue Jun 11, 2021 · 9 comments
Labels
elixir This work requires Elixir changes enhancement New feature or request help wanted Extra attention is needed tailwind This work requires TailwindCSS changes

Comments

@doomspork
Copy link
Member

doomspork commented Jun 11, 2021

I'm going to use this issue to outline what remains to get this iteration of Elixir School live 🚀

Must Have

  1. Update Lessons menu to be more responsive. cc @burden
  2. Move gettext into external repo to keep translation materials together. Note: The downside here is keeping them updated. I will tackle this.
  3. Automated deploys for changes to both repositories Trigger Heroku Deploy Action on merge of elixirschool/elixirschool repo. #20
  4. Announcement blog post

Nice to Have

  1. Add code examples to homepage and Why Elixir? pages Code examples for homepage and "why elixir?" #32
  2. Blog RSS feed. We have this currently so it would be a loss of functionality for a short time. I could see this being move to Must Have. Implement RSS feed support for the blog #54
  3. Sitemap.xml Create a Mix Task to generate a sitemap.xml #62
  4. Expand on the Why Elixir and homepage copy
  5. Document project
@doomspork doomspork added enhancement New feature or request help wanted Extra attention is needed tailwind This work requires TailwindCSS changes elixir This work requires Elixir changes labels Jun 11, 2021
@kinson
Copy link
Contributor

kinson commented Jun 11, 2021

@doomspork I am taking a stab at the first item on the must have list right now as a part of #9 . If you'd rather @burden (avoiding re-notifying them) tackle it, I can help with something else on this list!

@doomspork
Copy link
Member Author

@kinson have at it! I think Mike is pretty swamped with work lately so I'm not sure what his availability is.

@doomspork
Copy link
Member Author

@gemantzu as a translator what are your thoughts on 2:

Move gettext into external repo to keep translation materials together. Note: The downside here is keeping them updated. I will tackle this.

Right now the gettext for Phoenix is in this repo and includes some content that needs translation. Everything else lives in the original repository.

@gemantzu
Copy link
Collaborator

I would say that if we won't have them inside the elixirschool lessons repo, don't move them, a third repo will overcomplicate things for translators. And would there be any benefit from that? when will you know when to force an update in the application if a gettext translation has changed? is there a way to automate this as well?

@doomspork
Copy link
Member Author

doomspork commented Jun 13, 2021

I'm suggesting moving them from https://github.com/elixirschool/school_house into https://github.com/elixirschool/elixirschool, alongside the lessons/posts.

I'm of the mind to leave this as is for now and if it becomes a hurdle for translators we can move them.

@doomspork
Copy link
Member Author

Merges of new content to elixirschool/elixirschool will now trigger a deploy here. There's an issue with the deploy (separate of that) that I need to resolve.

@kinson I just realized we're both in Denver 🎉 We should grab coffee one day, my treat 😁

@kinson
Copy link
Contributor

kinson commented Jun 13, 2021

@doomspork great idea! I am not sure what your preferred method of chat is, but feel free to send me an email at [email protected] and we can find a time & place that works!

@doomspork
Copy link
Member Author

Email sent 🚀

I felt super motivated this weekend so I've been working my way through the list. I've got a PR open for sitemap and rss mix tasks #64 if someone wants to take a peek. There's also #60 which I updated to reply on a Makefile instead of mix task so it was easier to use in Docker pre-compile.

@doomspork
Copy link
Member Author

I've started on the blog post for this announcement 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir This work requires Elixir changes enhancement New feature or request help wanted Extra attention is needed tailwind This work requires TailwindCSS changes
Projects
None yet
Development

No branches or pull requests

3 participants