Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

chore: fix issues with golangci-lint #613

Merged
merged 8 commits into from
Jan 19, 2021
Merged

chore: fix issues with golangci-lint #613

merged 8 commits into from
Jan 19, 2021

Conversation

mdelapenya
Copy link
Contributor

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

What does this PR do?

It removes the go-vet hook as it's already enabled at golangci-lint hook

Why is it important?

There are a few open PRs at the precommit golang repo (https://github.com/dnephin/pre-commit-golang/pulls) about how go-vet behaves when there is a root directory without Go files.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

Follow-ups

We still need to fix golangci-lint

@mdelapenya mdelapenya self-assigned this Jan 18, 2021
@mdelapenya mdelapenya requested a review from a team January 18, 2021 21:13
@mdelapenya mdelapenya marked this pull request as ready for review January 18, 2021 21:14
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 18, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: mdelapenya commented: jenkins run the tests please

    • Start Time: 2021-01-19T10:23:02.505+0000

  • Duration: 23 min 9 sec

  • Commit: f757a41

Test stats 🧪

Test Results
Failed 0
Passed 105
Skipped 9
Total 114

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 105
Skipped 9
Total 114

@mdelapenya mdelapenya changed the title chore: go vet is already called by golangci-lint chore: fix issues with golangci-lint Jan 19, 2021
@mdelapenya
Copy link
Contributor Author

jenkins run the tests please

@mdelapenya mdelapenya merged commit 1485e9c into elastic:master Jan 19, 2021
@mdelapenya mdelapenya mentioned this pull request Jan 19, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (elastic#613)
8fd2670 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
@mdelapenya mdelapenya mentioned this pull request Jan 19, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (elastic#613)
70c6212 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
@mdelapenya mdelapenya mentioned this pull request Jan 19, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (elastic#613)
a8e744f 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
@mdelapenya mdelapenya mentioned this pull request Jan 19, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (elastic#613)
6221dae 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
mdelapenya added a commit that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (#613) (#614)
2ced8de 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
mdelapenya added a commit that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (#613) (#616)
bf09f34 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
mdelapenya added a commit that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (#613) (#617)
36bb941 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
mdelapenya added a commit that referenced this pull request Jan 19, 2021
@mdelapenya
chore: fix issues with golangci-lint (#613) (#615)
c97785f 
* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
@mdelapenya mdelapenya deleted the precommit-go branch January 19, 2021 17:17
@mdelapenya mdelapenya mentioned this pull request Oct 26, 2021
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cachedout cachedout cachedout approved these changes

@v1v v1v v1v approved these changes

Assignees

@mdelapenya mdelapenya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdelapenya @elasticmachine @cachedout @v1v