Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

chore: fix issues with golangci-lint (#613) backport for 6.8.x #617

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

mdelapenya
Copy link
Contributor

Backports the following commits to 6.8.x:

* chore: go vet is already called by golangci-lint

See dnephin/pre-commit-golang#62 (comment)
and https://golangci-lint.run/usage/linters/

* chore: bump precommit-golang

* chore: run golangci-lint for modified files

Enable the fast linter preset and only run it on newly-modified files,
and fix problems as they arise, if the linter supports it

* chore: fix line endings

* chore: expllicitly set filepaths for gherkin files

* chore: remove trail comma in arrays' last items

* chore: add empty Go file to the root directory

Golangci-lint is able to continue

* chore: add Go license to empty file
@mdelapenya mdelapenya self-assigned this Jan 19, 2021
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #617 opened

    • Start Time: 2021-01-19T14:36:26.703+0000
  • Duration: 26 min 21 sec

  • Commit: a8e744f

Test stats 🧪

Test Results
Failed 0
Passed 107
Skipped 7
Total 114

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 107
Skipped 7
Total 114

@mdelapenya mdelapenya merged commit 36bb941 into elastic:6.8.x Jan 19, 2021
@mdelapenya mdelapenya deleted the backport/6.8.x/pr-613 branch June 2, 2021 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants