feat: add track associations based on raw hit association, weighted by number of hits #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: tracking
wdconinc
force-pushed
the
track-associations
branch
from
6fce7ad to
f604db5
Compare
Capybara summary for PR 1564 |
bschmookler
reviewed
Aug 9, 2024
bschmookler
reviewed
Aug 9, 2024
|
|
I propose to ignore sonarcloud since I don't see why there is any duplicated code here... |
veprbl
approved these changes
Aug 14, 2024
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
### Briefly, what does this PR introduce? The #1564 had implemented meaningful associations based on hits used. That information became available for Tracks, but end users use ReconstructedParticles, and that's what we'd like to have implemented in this PR. Closes: #1356 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No There will be new warnings like ``` [PFRICH:RICHEndcapNLUTPID] [warning] Found a duplicate association for ReconstructedParticle at index 18 [PFRICH:RICHEndcapNLUTPID] [warning] The previous MCParticle was at 149 and the duplicate is at 200 ``` those are mostly harmless and are to be addressed separately. ### Does this PR change default behavior? Yes --------- Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR builds on #1535 to create
edm4eic::Trackassociations toedm4hep::MCParticles. Results in weights like this:What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.