Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracksToParticles: propagate MC associations from Tracks #1589

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 20, 2024

Briefly, what does this PR introduce?

The #1564 had implemented meaningful associations based on hits used. That information became available for Tracks, but end users use ReconstructedParticles, and that's what we'd like to have implemented in this PR.

Closes: #1356

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

There will be new warnings like

[PFRICH:RICHEndcapNLUTPID] [warning] Found a duplicate association for ReconstructedParticle at index 18
[PFRICH:RICHEndcapNLUTPID] [warning] The previous MCParticle was at 149 and the duplicate is at 200

those are mostly harmless and are to be addressed separately.

Does this PR change default behavior?

Yes

@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Aug 20, 2024
@veprbl veprbl requested review from a team and wdconinc and removed request for a team August 21, 2024 21:20
wdconinc
wdconinc previously approved these changes Aug 22, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

src/algorithms/tracking/TracksToParticles.cc Outdated Show resolved Hide resolved
src/algorithms/tracking/TracksToParticles.cc Show resolved Hide resolved
Copy link

@veprbl veprbl enabled auto-merge August 22, 2024 13:23
@veprbl veprbl added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 240d927 Aug 22, 2024
89 checks passed
@veprbl veprbl deleted the pr/propagate_track_assoc branch August 22, 2024 13:40
@veprbl veprbl added this to the 24.09.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants