Add one-to-one relation with raw tracker/calorimeter hit for reconstructed tracker/calorimeter hit #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: tracking
rahmans1
changed the title
rahmans1
changed the title
rahmans1
changed the title
rahmans1
changed the title
veprbl
reviewed
Jul 28, 2024
|
I think there is a desire to move forward on tracking here, where the implementation is essentially complete thanks to one-to-one associations and relations, but I fear that if we add calorimeter hit associations and relations to the scope of this PR it will be slowed down. In particular, the CalorimeterHitDigi does pre-digitization merging of SimCalorimeterHits, so the associations are going to be requiring some non-trivial code. So, I suggest we keep this PR for tracker (and photomultiplier) hits only, and create a similar PR for calorimeters that may need more non-trivial code. |
In particular, we want more than just the leading hit in EICrecon/src/algorithms/calorimetry/CalorimeterHitDigi.cc Lines 190 to 194 in ec93c74 and that then requires that we decide on a weight strategy ( hit.getEnergy() / edep probably).
|
rahmans1
force-pushed
the
rahmans1-patch-1
branch
from
2c244b3 to
3132e8d
Compare
veprbl
reviewed
Aug 5, 2024
veprbl
reviewed
Aug 5, 2024
veprbl
reviewed
Aug 5, 2024
wdconinc
reviewed
Aug 6, 2024
Capybara summary for PR 1535 |
veprbl
reviewed
Aug 7, 2024
for more information, see https://pre-commit.ci
This cannot go in until all references to edm4hep::RawCalorimeterHit is replaced by edm4eic::RawCalorimeterHit
rahmans1
force-pushed
the
rahmans1-patch-1
branch
from
fdbe7ac to
b00a3fd
Compare
|
veprbl
approved these changes
Aug 7, 2024
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
…y number of hits (#1564) ### Briefly, what does this PR introduce? This PR builds on #1535 to create `edm4eic::Track` associations to `edm4hep::MCParticles`. Results in weights like this: ``` events->Draw("CentralCKFTrackAssociations.weight") ```  ``` events->Draw("sqrt(MCParticles[_CentralCKFSeededTrackAssociations_sim.index].momentum.x**2+MCParticles[_CentralCKFSeededTrackAssociations_sim.index].momentum.y**2+MCParticles[_CentralCKFSeededTrackAssociations_sim.index].momentum.z**2)") ```  ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue: track associations) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Add one-to-one relation with raw tracker/calorimeter hit for reconstructed tracker/calorimeter hit. Contingent on eic/EDM4eic#86.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?