Created algorithm and factory for calculating hadronic final state variables #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks @veprbl , I agree that I had left out some necessary guards. Have added them now (not yet pushed though). I'm having a different problem now. When I compile against my version of |
|
@veprbl Pushed with additional guards. Passes build checks now. |
…ing-hadronic-final-state-variables
|
EDM4eic 6 should be in the nightly now, let's see how that fares. |
veprbl
approved these changes
May 6, 2024
|
(Tested that the values are indeed filled) |
veprbl
deleted the
1362-need-algorithm-and-factory-for-calculating-hadronic-final-state-variables
branch
ajentsch
pushed a commit
that referenced
this pull request
May 20, 2024
…riables (#1405) ### Briefly, what does this PR introduce? This adds and algorithm and corresponding factory for calculating hadronic final state variables. Since this uses a new `EDM4eic` data type not included in major release 5, the algorithm is only called for major release >= 6. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #1362 ) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This adds and algorithm and corresponding factory for calculating hadronic final state variables. Since this uses a new
EDM4eicdata type not included in major release 5, the algorithm is only called for major release >= 6.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?