Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need algorithm and factory for calculating hadronic final state variables #1362

Closed
tylerkutz opened this issue Apr 3, 2024 · 0 comments · Fixed by #1405
Closed

Need algorithm and factory for calculating hadronic final state variables #1362

tylerkutz opened this issue Apr 3, 2024 · 0 comments · Fixed by #1405

Comments

@tylerkutz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
New EDM4eic data type HadronicFinalState needs to be filled/saved to PODIO output.

Describe the solution you'd like
Calculate variables and save to output.

Describe alternatives you've considered
None

Additional context
These variables will be used in kinematic reconstruction algorithms, electron ID algorithms, and saved in the output to be used for analysis cuts.

@tylerkutz tylerkutz linked a pull request Apr 4, 2024 that will close this issue
7 tasks
github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
…riables (#1405)

### Briefly, what does this PR introduce?

This adds and algorithm and corresponding factory for calculating
hadronic final state variables. Since this uses a new `EDM4eic` data
type not included in major release 5, the algorithm is only called for
major release >= 6.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #1362 )
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dmitry Kalinkin <[email protected]>
ajentsch pushed a commit that referenced this issue May 20, 2024
…riables (#1405)

### Briefly, what does this PR introduce?

This adds and algorithm and corresponding factory for calculating
hadronic final state variables. Since this uses a new `EDM4eic` data
type not included in major release 5, the algorithm is only called for
major release >= 6.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #1362 )
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant