Add association between raw tracker/calorimeter hit and tracker/calorimeter hit #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
wdconinc
reviewed
Jul 26, 2024
wdconinc
reviewed
Jul 26, 2024
wdconinc
reviewed
Jul 26, 2024
wdconinc
reviewed
Jul 26, 2024
wdconinc
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Looks good! I think this adds the remaining links at the input of the tracker and calorimeter chains.
We discussed this yesterday and we think there is no need for a weight in the TrackerHit and CalorimeterHit, nor is there a need for a OneToManyRelations in these data types.
wdconinc
previously approved these changes
Jul 26, 2024
veprbl
previously approved these changes
Jul 26, 2024
Reco always matches with one raw hit
…mbiguity in nomenclature.
rahmans1
force-pushed
the
rahmans1-patch-1
branch
from
a0eb84c to
cd75170
Compare
rahmans1
changed the title
This reverts commit cd75170.
wdconinc
approved these changes
Jul 26, 2024
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Aug 7, 2024
…ucted tracker/calorimeter hit (#1535) ### Briefly, what does this PR introduce? Add one-to-one relation with raw tracker/calorimeter hit for reconstructed tracker/calorimeter hit. Contingent on eic/EDM4eic#86. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <[email protected]> Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Add association between raw tracker hit and tracker hit to have full association path from MCParticle to tracker hit.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?