made FilterQuality configurable for Resizetizer

[thisisthekap]

Description of Change

Made FilterQuality configurable for Resizetizer. Default value is SKFilterQuality.High (like it was hard coded before).

Issues Fixed

Fixes #25750

Documentation

Adapted documentation in dotnet/docs-maui#2604

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[thisisthekap]

@jsuarezruiz I think that the failing CI is unrelated to my changes.

[rmarinho]

/rebase

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

How does this fix the issue? The filter quality should just be configuring the antialiasing and similar. The image should be the same size.

Are the generated images smaller after this PR?

[thisisthekap]

This PR enables us to set the quality to 'None' which was the old default behavior. For our case, this reduces our app size tremendously. Later on we will try to fix our image resolutions to have a working setup with better antialiasing. But for the sake of keeping the old behavior, we need this PR.

[rmarinho]

/rebase

[rmarinho]

/azp run maui-public maui-uitests-public

[azure-pipelines]

No pipelines are associated with this pull request.

[rmarinho]

/azp run maui-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rmarinho]

Build seems to be failing ...

D:\a\_work\1\s\eng\ILRepack.targets(126,3): error MSB3073: The command ""D:\a\_work\1\s\eng\ILRepack.exe" /out:"D:\a\_work\1\s\artifacts\bin\Resizetizer\Release\netstandard2.0\ILRepacked\Microsoft.Maui.Resizetizer.dll" "D:\a\_work\1\s\artifacts\bin\Resizetizer\Release\netstandard2.0\Microsoft.Maui.Resizetizer.dll" /ver:42.42.42.42424 /internalize /keyfile:"D:\a\_work\1\s\eng/microsoft.maui.controls.snk" /lib:"C:\Users\cloudtest\.nuget\packages\netstandard.library\2.0.3\build\netstandard2.0\ref"" exited with code 1. [D:\a\_work\1\s\src\SingleProject\Resizetizer\src\Resizetizer.csproj]
    22 Warning(s)
    1 Error(s)

[thisisthekap]

@rmarinho As I already included this PR in our custom build, I am not sure if my changes caused these build issues. Could you provide more detail on the build failure?

[mattleibow]

This PR has some value in and of itself - the attribute will allow people to decided to render images at a lower quality. But, the only reason today is because higher quality is a large png that was upscaled.

See more: #25750 (comment)

I am thinking that maybe we first evaluate whether we should be upscaling (buth this app and resizetizer as a whole).

[albilaga]

I am thinking that maybe we first evaluate whether we should be upscaling (buth this app and resizetizer as a whole).

@mattleibow I am not sure if we really need that. Well, we can do that but we should also give options of the people to override the quality itself. Maybe for large image MAUI team see no benefit on upscaling but then when we tested on iPad or tablet we definitely saw the need the upscaling. So yes, I agree if resizetizer maybe can be smart on what decide the image need to be upscaled or not. But user should still given the option to override that as they test it themselves

[mattleibow]

Makes sense. Interesting tho that skia upscaling is better than ios default. I would have thought that it was the other way around.

So yeah, let me review.

[thisisthekap]

@mattleibow Maybe an additional bool property AllowUpscale would be benefitial?

Edit: What I am thinking of is to have good default values, but to give the developers out there a highly customizable experience if they need to do so.

[albilaga]

@mattleibow I think this is also because we use the base highest image as the image. So want to clarify
If I have image with resolution 1000x1000 and we set BaseSize="250,250" what will happen? Is the image will be use our image as the highest resolution and then downscale for lower density or it is will be our image downscaled to 250x250 and then upscaled again to 1000x1000?

[thisisthekap]

@mattleibow @jsuarezruiz I would like to make another property configurable. The Encode call when saving a resized image is always using quality 100. I want to make that EncodingQuality configurable. Would it be feasible to add that in this PR, or should I create a separate one?