Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for https://github.com/dotnet/maui/pull/25686 #2604

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thisisthekap
Copy link

Added documentation for dotnet/maui#25686

@davidbritch
Copy link
Contributor

Thanks for the PR @thisisthekap

I'll sit on it until the feature is merged and in an official release.


The underlying [SKFilterQuality](https://github.com/mono/SkiaSharp/blob/f9bf4512767c9de22b6683e573b145ce5f0ce0a9/binding/SkiaSharp/SKPaint.cs#L17) used to compress the images is set to `SKFilterQuality.High` by default.

With https://github.com/dotnet/maui/pull/25686 a new configuration property `FilterQuality` was introduced that can be set to any member of `SKFilterQuality`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to use the wording "property" here, when the end user will need to specify an "attribute" on the MauiImage Item?

I know the property was added in the class but that is an internal class which the user will not be able to use.
And we don't want to confuse it with an MSBuild property.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants