chore: Update testing, iconography, and formatting #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR modernizes the codebase to support Django CMS 4.x by updating build configurations, testing infrastructure, and form field names. The changes include migrating from setup.py to pyproject.toml, updating CI workflows for newer Python/Django versions, and refactoring form fields for better clarity. ER diagram for form field changeserDiagram
EXPORT_IMPORT_FORM {
ModelChoiceField cms_pagecontent
}
PAGE_CONTENT {
admin_manager latest_content
}
EXPORT_IMPORT_FORM }|--|| PAGE_CONTENT : uses
note for EXPORT_IMPORT_FORM "Refactored 'cms_page' to 'cms_pagecontent'"
note for PAGE_CONTENT "Updated queryset to use 'admin_manager.latest_content()'"
Updated class diagram for ExportImportFormclassDiagram
class ExportImportForm {
+ModelChoiceField cms_pagecontent
+clean()
}
class PluginExportForm {
+get_filename()
+run_export()
}
class PluginImportForm {
+clean()
+run_import()
}
ExportImportForm <|-- PluginExportForm
ExportImportForm <|-- PluginImportForm
note for ExportImportForm "Refactored 'cms_page' to 'cms_pagecontent'"
note for PluginExportForm "Updated methods to use 'cms_pagecontent'"
note for PluginImportForm "Updated methods to use 'cms_pagecontent'"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @fsbraun - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+76
to
86
| if placeholder and (cms_pagecontent or plugin): | ||
| message = _( | ||
| "Plugins can be imported to pages, plugins or placeholders. Not all three." | ||
| ) | ||
| raise forms.ValidationError(message) | ||
|
|
||
| if plugin and (cms_page or placeholder): | ||
| message = _("Plugins can be imported to pages, plugins or placeholders. Not all three.") | ||
| if plugin and (cms_pagecontent or placeholder): | ||
| message = _( | ||
| "Plugins can be imported to pages, plugins or placeholders. Not all three." | ||
| ) | ||
| raise forms.ValidationError(message) |
There was a problem hiding this comment.
issue (code-quality): Remove redundant conditional [×2] (remove-redundant-if)
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 62.12% 57.92% -4.21%
==========================================
Files 11 11
Lines 404 404
Branches 61 62 +1
==========================================
- Hits 251 234 -17
- Misses 137 152 +15
- Partials 16 18 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…fer into chore/testing
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…fer into chore/testing
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @fsbraun - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
vinitkumar
reviewed
Nov 20, 2024
vinitkumar
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare release 2.0.0a
#38 brings django CMS 4 support. This PR updates the build pipeline and testing.
Refactor the codebase to update form field names for clarity, migrate build configuration to pyproject.toml, and update CI workflows and test configurations to support newer Python and Django CMS versions.
Enhancements:
Build:
CI:
Tests:
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.
Summary by Sourcery
Update the project to support Django CMS 4 by refactoring form fields, migrating build configuration to pyproject.toml, and updating CI workflows and test configurations for newer Python and Django CMS versions.
Enhancements:
Build:
CI:
Tests: