-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2024.11.0
#548
Release 2024.11.0
#548
Conversation
Change language to gender neutral language
…ack_darkmode Fix colors of feedback list in dark mode
…_form Refactor "toggle_plural_field.js"
Update dependencies
As explained in #549 I think this PR should be named either |
Prepare release `2024.11.0`
CircleCI: Fix `publish-package` step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. All in all this looks good to me. The core functions all worked for me and also all of the new features worked for me.
I noticed two minor things, but I think it's okay to release before having fixed them, therefore I will already approve :)
- I noticed that there is a JS error (at least on list of vocabularies/documents, list of modules/training set and list of professions/disciplines).
- I also noticed, that I can select
die (Plural)
as an option also for verbs, adverbs, adjectives, numerals and pronouns. I can't remember what the requirements were and if this should be suppressed, but thought it was at least worth mentioning
@JoeyStk Thanks for the thorough review! On 1) I cannot see a JS error in the list views, only a deprecation warning. I'll get back to you and if we can reproduce the error, I'll take care of it in a follow-up :-) On 2) Good catch! Behavior is a little bit weird but does not differentiate from the current state on the |
Short description
lunes-cms
2024.11.0
Proposed changes