Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.11.0 #548

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Release 2024.11.0 #548

merged 12 commits into from
Nov 22, 2024

Conversation

sascha11110
Copy link
Contributor

@sascha11110 sascha11110 commented Oct 30, 2024

Short description

lunes-cms 2024.11.0

Proposed changes

  • [ #512 ] Gender neutral language
  • [ #532 ] Fix color of feedback list in dark mode
  • [ #544 ] Refactoring of toggle_plural_field.js
  • [ #546 ] Update dependencies

@sascha11110 sascha11110 requested a review from a team as a code owner October 30, 2024 15:21
@sascha11110 sascha11110 changed the title Release 2024.7.0 Release 2024.7.0 Oct 30, 2024
@sascha11110 sascha11110 marked this pull request as draft October 30, 2024 16:15
@JoeyStk
Copy link
Contributor

JoeyStk commented Oct 31, 2024

As explained in #549 I think this PR should be named either 2024.10.0 or 2024.11.0 after the month we release in :)

@sascha11110 sascha11110 changed the title Release 2024.7.0 Release 2024.11.0 Oct 31, 2024
@sascha11110 sascha11110 marked this pull request as ready for review November 4, 2024 08:57
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. All in all this looks good to me. The core functions all worked for me and also all of the new features worked for me.

I noticed two minor things, but I think it's okay to release before having fixed them, therefore I will already approve :)

  1. I noticed that there is a JS error (at least on list of vocabularies/documents, list of modules/training set and list of professions/disciplines).
  2. I also noticed, that I can select die (Plural) as an option also for verbs, adverbs, adjectives, numerals and pronouns. I can't remember what the requirements were and if this should be suppressed, but thought it was at least worth mentioning

@sascha11110
Copy link
Contributor Author

sascha11110 commented Nov 22, 2024

@JoeyStk Thanks for the thorough review!

On 1) I cannot see a JS error in the list views, only a deprecation warning. I'll get back to you and if we can reproduce the error, I'll take care of it in a follow-up :-)

On 2) Good catch! Behavior is a little bit weird but does not differentiate from the current state on the main branch. I've created a ticket for that: #551

@sascha11110 sascha11110 merged commit a9f12f5 into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants