Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

983: Upgrade dependencies #1013

Merged
merged 8 commits into from
Apr 10, 2024
Merged

983: Upgrade dependencies #1013

merged 8 commits into from
Apr 10, 2024

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle steffenkleinle commented Mar 26, 2024

Short description

Upgrade most dependencies.

Proposed changes

  • Upgrade most dependencies
  • Fix jest setup and align jest.config.ts to integreat
  • Extract and fix getGalleryPermission()
  • Fix a few wrong and tests asserting on styles
  • Fix some types
  • Uncomment tests with ByRole queries, should be fixed in react-native upgrade (Upgrade react-native #1010)

Separate PR for an upgrade of prettier: #1014.

Created separate tickets for upgrading

Tickets already existing for upgrades/migrations:

Ticket for unmaintained dependencies:
#1015.

Side effects

Hopefully none.

Resolved issues

Fixes: #983.


@steffenkleinle steffenkleinle linked an issue Mar 26, 2024 that may be closed by this pull request
@steffenkleinle steffenkleinle force-pushed the 983-upgrade-dependencies branch from 45bb136 to aa5cc47 Compare March 26, 2024 17:13
@steffenkleinle steffenkleinle force-pushed the 983-upgrade-dependencies branch from 76f6c59 to ba62b06 Compare March 26, 2024 17:45
@steffenkleinle steffenkleinle marked this pull request as ready for review March 27, 2024 13:32
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android, works as expected 🚀
Thanks for updating 🙏

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thank you! Tested on real iOS
There were a few issues that I had to solve to get it running on iOS (I'll push them in a minute):

Would appreciate someone else checking on iOS @ztefanie @f1sh1918

jest.config.ts Show resolved Hide resolved
jest.config.ts Show resolved Hide resolved
jest.config.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/__tests__/Button.spec.tsx Show resolved Hide resolved
src/routes/repetition/RepetitionScreen.tsx Show resolved Hide resolved
src/services/AsyncStorage.ts Show resolved Hide resolved
@ztefanie
Copy link
Member

ztefanie commented Apr 8, 2024

Does not work for me on mac,
Screenshot 2024-04-08 at 09 58 11

I deleted the pods folder, cleared the pod cache and reinstalled everything.

@ztefanie
Copy link
Member

ztefanie commented Apr 8, 2024

Could be due to outdated OS (and therefore xcode version) of my mac.

@steffenkleinle
Copy link
Member Author

@ztefanie @LeandraH should I wait with merging until you have a new mac and can test this?

@ztefanie
Copy link
Member

ztefanie commented Apr 9, 2024

@ztefanie @LeandraH should I wait with merging until you have a new mac and can test this?

Maybe @f1sh1918 can test it?

@f1sh1918
Copy link
Contributor

f1sh1918 commented Apr 9, 2024

leandras approve should be sufficient? @steffenkleinle

@LeandraH
Copy link
Contributor

LeandraH commented Apr 9, 2024

Since I now wrote part of the code, I feel like another person should test the part that I wrote. But that might be paranoia on my part :)

@steffenkleinle
Copy link
Member Author

I am fine with both, will be tested by Martin before a production release again anyway right? Also @LeandraH I think you just made sure that dependencies are correctly picked up for iOS, you didn't change any user-visible code. So I think we could merge this from my perspective.

@LeandraH
Copy link
Contributor

LeandraH commented Apr 9, 2024

Works for me

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ios

@steffenkleinle steffenkleinle merged commit 2cc25e6 into main Apr 10, 2024
2 checks passed
@steffenkleinle steffenkleinle deleted the 983-upgrade-dependencies branch April 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Dependencies
4 participants